Skip to content
This repository has been archived by the owner on Sep 17, 2024. It is now read-only.

Fix support for retail tukui/elvui addons via their download pages #141

Merged
merged 2 commits into from
Apr 30, 2020
Merged

Fix support for retail tukui/elvui addons via their download pages #141

merged 2 commits into from
Apr 30, 2020

Conversation

grrttedwards
Copy link
Owner

@grrttedwards grrttedwards commented Apr 28, 2020 •
edited
Loading

Test cases:

1

urls:

https://www.tukui.org/classic-addons.php?id=1
https://www.tukui.org/classic-addons.php?id=2

results in

> pipenv run python -m updater -c .\config-test.ini
Installing/updating addon: Tukui to version: 1.36...

Installing/updating addon: ElvUI to version: 1.24...



Name           Prev. Version  New Version
────           ─────────────  ───────────
Tukui          -----          1.36
ElvUI          -----          1.24

in folder:

image

2

urls:
https://www.tukui.org/addons.php?id=3
https://www.tukui.org/download.php?ui=tukui
https://www.tukui.org/download.php?ui=elvui

results in:

> pipenv run python -m updater -c .\config-test.ini
Installing/updating addon: Tukui to version: 18.28...

Installing/updating addon: ElvUI to version: 11.372...

Installing/updating addon: AddOnSkins to version: 4.40...



Name           Prev. Version  New Version
────           ─────────────  ───────────
Tukui          -----          18.28
AddOnSkins     -----          4.40
ElvUI          -----          11.372

in folder:

image

@grrttedwards grrttedwards mentioned this pull request Apr 28, 2020
Closed
@grrttedwards
Copy link
Owner Author

Still need to add automated tests against this

@grrttedwards grrttedwards changed the base branch from master to develop April 30, 2020 01:35
@grrttedwards grrttedwards marked this pull request as ready for review April 30, 2020 01:36
@grrttedwards grrttedwards merged commit 38c6298 into develop Apr 30, 2020
@grrttedwards grrttedwards deleted the fix-tukui-retail branch April 30, 2020 01:39
@grrttedwards grrttedwards mentioned this pull request Apr 30, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@grrttedwards