Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go version to go1.17 everywhere #336

Merged
merged 2 commits into from
Nov 21, 2022

Conversation

wanlin31
Copy link
Collaborator

@wanlin31 wanlin31 commented Nov 19, 2022

This change matches grpc/grpc-go#5477.

@wanlin31
Copy link
Collaborator Author

This also affecting the CIs

@wanlin31 wanlin31 requested a review from paulosjca November 19, 2022 01:46
@wanlin31 wanlin31 marked this pull request as ready for review November 19, 2022 01:46
@wanlin31 wanlin31 self-assigned this Nov 19, 2022
@wanlin31 wanlin31 added the release notes: yes Indicates that PR needs to be in release notes label Nov 19, 2022
This PR bump go version from 1.16 to 1.17 throughout the repo.
@wanlin31 wanlin31 force-pushed the update-go-build-version branch from 6125945 to 7001ea8 Compare November 19, 2022 01:58
@wanlin31 wanlin31 changed the title Bump up go version in build image of golang tests. Bump up go version everywhere. Nov 19, 2022
Copy link
Collaborator

@paulosjca paulosjca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you are missing changes in some places. I would run the following:

find . -type f | xargs -r sed -i -e s/golang:1.16/golang:1.17/g
go get ./...
go mod tidy -compat=1.17

I have already tested a complete CI run with these changes on the benchmarks-dev1 cluster, so that should do the trick.

After submitting this, I would make the next release version 1.5.0, since we are changing compatibility.

@paulosjca paulosjca changed the title Bump up go version everywhere. Update go version in go.mod to go1.17 Nov 21, 2022
@paulosjca paulosjca changed the title Update go version in go.mod to go1.17 Update go version to go1.17 everywhere Nov 21, 2022
@paulosjca paulosjca self-requested a review November 21, 2022 20:52
@paulosjca paulosjca merged commit c80684e into grpc:master Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release notes: yes Indicates that PR needs to be in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants