Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for Prometheus scrape interval and query delay. #331

Merged
merged 3 commits into from
Nov 18, 2022
Merged

Add documentation for Prometheus scrape interval and query delay. #331

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ccc9c73
Add documentation for Prometheus scrape interval and query daley.
wanlin31 Nov 10, 2022
097b02d
Address comment.
wanlin31 Nov 17, 2022
aae227f
Address comment.
wanlin31 Nov 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions config/prometheus/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,3 +29,20 @@ The files [install-prometheus.yaml](install-prometheus.yaml) and
[servicemonitors.yaml](servicemonitors.yaml) are taken from
[istio/tools](https://github.com/istio/tools/), with configuration related to
Istio left out.

### Prometheus scrape interval

The scrape interval (`scrape_interval`) determines how often Prometheus scrapes
targets. The default value for this interval is
[1m](https://prometheus.io/docs/prometheus/latest/configuration/configuration/).
We change this interval in our configuration to 1s, since our tests typically
last only 30s. See <https://github.com/grpc/test-infra/pull/325> for details.

### Query delay

We add 20s delay before collecting data from Prometheus, in the tests that use
Prometheus. This delay allows data to become available
([cAdvisor housekeeping interval](https://github.com/google/cadvisor/blob/master/docs/runtime_options.md#housekeeping))
and pulled by Prometheus
([Prometheus scrape interval](https://github.com/grpc/test-infra/pull/325)). See
<https://github.com/grpc/test-infra/pull/330> for details.