Make collection of Prometheus data be controlled by an annotation. #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we automatically collect Prometheus data for PSM related tests, now some regular tests (same scenario as PSM test) are also part of the PSM tests, we may want to collect Prometheus data for those regular tests too. The current method for checking if a rest is a PSM test to check the existence of xds-server and sidecar containers. It is hard to apply the same mechanism for PSM related regular tests, the simplest way is to add an annotation like `enablePrometheus:true` to control if we want to use Prometheus for a given test.
wanlin31
force-pushed
the
update-prometheus
branch
from
ae358bc to
b5036e9
Compare
wanlin31
force-pushed
the
update-prometheus
branch
2 times, most recently
from
3d2a363 to
8da69cf
Compare
wanlin31
force-pushed
the
update-prometheus
branch
from
8da69cf to
408e82a
Compare
wanlin31
changed the title
wanlin31
added
the
release notes: yes
paulosjca
reviewed
Jul 22, 2022
There was a problem hiding this comment.
I would also modify the PSM examples to add the enablePrometheus annotation, and modify the kokoro jobs to include it.
I also notice that there is no mention of Prometheus in the README files, we should update the documentation as well (perhaps as a separate PR).
wanlin31
force-pushed
the
update-prometheus
branch
from
81a181f to
14bd481
Compare
|
The loadtest_examples.sh are updated in grpc/grpc#30452 All examples from this PR are generated by loadtest_examples.sh. |
paulosjca
reviewed
Aug 1, 2022
paulosjca
changed the title
paulosjca
approved these changes
Aug 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we automatically collect Prometheus data for PSM
related tests, now some regular tests (same scenario as PSM
test) are also part of the PSM tests, we may want to collect
Prometheus data for those regular tests too. The current method
for checking if a test isPSM related is to check the existence of
xds-server and sidecar containers.
The default behavior is to not collect any Prometheus data.
This PR adds an annotation
enablePrometheustoelect to collect Prometheus data, once this annotation is
set to
truein a LoadTest configuration, thePrometheus data would be collected for that particular test.