Update support for csharp core implementation. #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wanlin31
added
the
release notes: yes
config/samples/README.md
Outdated
| Special considerations is required for running csharp examples, the support of | ||
| csharp in [grc/grpc](https://github.com/grpc/grpc) is removed by | ||
| <https://github.com/grpc/grpc/pull/29225>, csharp benchmark test is only | ||
| supported by version v1.45.2 and earlier versions. |
There was a problem hiding this comment.
FYI C# is still available in gRPC core release v1.46.x (it's removed starting from 1.47.x i.e. the current master branch).
There was a problem hiding this comment.
Thanks for letting me know! Updated!
jtattermusch
approved these changes
May 27, 2022
paulosjca
approved these changes
May 31, 2022
wanlin31
added a commit
to wanlin31/test-infra
that referenced
this pull request
Jun 15, 2022
* Update support for csharp core implementation. Co-authored-by: Paulo Castello da Costa <pcastello@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the proper error message in the Dockerfiles
when user trying to build the csharp benchmark worker with
an incompatible grpc/grpc version.
This commit also add explanation for csharp example in
README.md in the config/sample folder.