Collect logs from all containers and add log to test properties. #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wanlin31
force-pushed
the
update-logger-for-multiple-container
branch
from
259d61c to
f3cf442
Compare
wanlin31
added
the
release notes: no
paulosjca
reviewed
Apr 21, 2022
wanlin31
changed the title
This commit specifies the container to collect the logs from when there are more than one run contaienrs exit.
This commit updates the logics to save logs from all containers to the original directory. The name of the logs follows the format: pod-name-container-name.log. This commit also add log url to the properties if the log url prefix is provided.
wanlin31
force-pushed
the
update-logger-for-multiple-container
branch
from
f3cf442 to
24fdf4d
Compare
wanlin31
changed the title
wanlin31
changed the title
wanlin31
added
release notes: yes
Updated the pr per comment. Verified by running experimental CI, details can be found in the bug. Also verified that not providing the |
paulosjca
reviewed
Apr 27, 2022
wanlin31
force-pushed
the
update-logger-for-multiple-container
branch
3 times, most recently
from
0c8bdc4 to
ffe8a5e
Compare
wanlin31
force-pushed
the
update-logger-for-multiple-container
branch
from
ffe8a5e to
65ccbc9
Compare
paulosjca
reviewed
May 2, 2022
paulosjca
reviewed
May 2, 2022
paulosjca
reviewed
May 3, 2022
wanlin31
force-pushed
the
update-logger-for-multiple-container
branch
from
ee5cef9 to
02bc620
Compare
wanlin31
force-pushed
the
update-logger-for-multiple-container
branch
from
02bc620 to
a89bad8
Compare
paulosjca
reviewed
May 9, 2022
paulosjca
approved these changes
May 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updated the infrastructure to save logs to file from all existing container which produces logs. We have also separate the property generation of name property and log properties to avoid dependencies.
We also add the log link to the Xunit reports when there are pod logs.