-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add examples for PSM tests. #278
Conversation
@gnossen Hi Richard, I create this PR to show the examples of the test configurations for PSM tests. We will need a new release of the test-infra to run them. The scenarios were adopted from the original load test examples (minus the security parameters) to show the ability to run the full flow, the scenarios can be modified later. |
- containers/runtime/xds/bootstrap.json | ||
command: | ||
- main | ||
image: gcr.io/grpc-testing/runtime/xds:test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, this image is fixed and has version "test¨? I assume it is going to be part of some release? Perhaps these examples, unlike the regular ones, should be templates already. In this case, we may want to put them in config/samples/templates/psm.
Also, the path of the images we use should probably be something like gcr.io/grpc-testing/e2etest/runtime/xds-server (or perhaps runtime/psm/xds-server if we want to emphasize that these are psm components).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, since they requires the images like the pre-built examples I think they should be templates .
For the pefix, I agree with setting PSM_IMAGE_PREFIX=gcr.io/grpc-testing/e2etest/runtime/psm to emphasize psm test. I will update them to be template.
I was able to generate template for proxyless tests use command below:
The ready-to-run configurations can be generated as:
Might need to change the names of the Templates. |
You will need two templates, one for proxied and one for proxyless, since they use different clients. |
Added three examples to run PSM tests. To run these test, a new deployment is required.