Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update PHP7 version for OSS benchmarks images. #234

Merged
merged 4 commits into from
Nov 9, 2021
Merged

Update PHP7 version for OSS benchmarks images. #234

merged 4 commits into from
Nov 9, 2021

Conversation

paulosjca
Copy link
Collaborator

@paulosjca paulosjca commented Nov 8, 2021 •
edited
Loading

  • Updates PHP7 image versions from php7.2.22-buster to php7.2.34-buster (latest is 7.4.25).
  • Updates gpg2 invocation to exclude unused key and remove hardcoded key server specification.
  • Proposed as an alternative to Cache RVM build keys to reduce flakiness. #233.

@paulosjca paulosjca added the release notes: yes Indicates that PR needs to be in release notes label Nov 8, 2021
@paulosjca paulosjca self-assigned this Nov 8, 2021
ybbbby
ybbbby reviewed Nov 8, 2021
View reviewed changes
containers/init/build/php7/Dockerfile
apt-get clean

# Install rvm
RUN apt-get update && apt-get install -y gnupg2 && apt-get clean
RUN gpg2 --keyserver keyserver.ubuntu.com --recv-keys 409B6B1796C275462A1703113804BB82D39DC0E3 7D2BAF1CF37B13E2069D6956105BD0E739499BDB
RUN gpg2 --recv-keys 7D2BAF1CF37B13E2069D6956105BD0E739499BDB
Copy link
Collaborator

@ybbbby ybbbby Nov 8, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This modification would make gpg2 request embedded key server for public key?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes this is the same as what happens for interop.

https://github.com/grpc/grpc/blob/73dcfd375d14c7cef537a5255767a8950424988c/tools/dockerfile/interoptest/grpc_interop_ruby/Dockerfile#L73

@paulosjca paulosjca marked this pull request as ready for review November 9, 2021 00:26
@paulosjca
Copy link
Collaborator Author

I propose to merge this PR and, if flakiness should reoccur, move to #233.

@paulosjca paulosjca mentioned this pull request Nov 9, 2021
Closed
@paulosjca paulosjca requested a review from ybbbby November 9, 2021 09:32
jtattermusch
jtattermusch approved these changes Nov 9, 2021
View reviewed changes
Copy link
Collaborator

@jtattermusch jtattermusch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fix. I'm wondering if this is actually going to help though. I guess we will see soon enough.

@paulosjca paulosjca merged commit 3cdc632 into grpc:master Nov 9, 2021
@paulosjca paulosjca deleted the cachekeys3 branch November 9, 2021 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtattermusch jtattermusch jtattermusch approved these changes

@wanlin31 wanlin31 Awaiting requested review from wanlin31

@ybbbby ybbbby Awaiting requested review from ybbbby

Assignees

@paulosjca paulosjca

Labels
release notes: yes Indicates that PR needs to be in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paulosjca @jtattermusch @ybbbby