A38: Admin Interface API #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanjaypujare
reviewed
Feb 1, 2021
sanjaypujare
reviewed
Feb 1, 2021
sanjaypujare
reviewed
Feb 1, 2021
sanjaypujare
reviewed
Feb 1, 2021
markdroth
reviewed
Feb 2, 2021
lidizheng
commented
Feb 5, 2021
There was a problem hiding this comment.
Thanks for the detailed review. The content of this design doc has been trimmed down as suggested.
@markdroth PTALA.
lidizheng
commented
Feb 26, 2021
voidzcy
reviewed
Mar 1, 2021
A38-admin-interface-api.md
Outdated
|
|
||
| ## Abstract | ||
|
|
||
| This proposal describes a convenience API in each gRPC language to improve the usability of creating a gRPC server with admin services to expose states in the gRPC library. |
There was a problem hiding this comment.
nit: s/convenience/convenient/ ?
markdroth
reviewed
Mar 1, 2021
menghanl
reviewed
Mar 1, 2021
|
@markdroth PTALAAA. I think all open comments are resolved in this gRFC, and the configuration dump part is split into another gRFC. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gRFC: https://github.com/lidizheng/proposal/blob/admin-interface/A38-admin-interface-api.md
This proposal describes a convenience API in each gRPC language to improve the usability of creating a gRPC server with admin services.