Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build different binaries for different libc’s (a.k.a. support alpine linux) #82

Merged
merged 2 commits into from
Nov 14, 2017

Conversation

bkw
Copy link
Contributor

@bkw bkw commented Nov 6, 2017

The latest version of node-pre-gyp supports using libc as a variable for binary names, making it possible to differentiate between glibc and musl of alpine linux.

Fixes #81.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@bkw
Copy link
Contributor Author

bkw commented Nov 6, 2017

CLA signed.

@googlebot
Copy link

CLAs look good, thanks!

@murgatroid99
Copy link
Member

Can you make the corresponding change to packages/grpc-native-core/templates/package.json.template?

@bkw
Copy link
Contributor Author

bkw commented Nov 7, 2017

Thanks for spotting that. Done in 4479312.

@bkw
Copy link
Contributor Author

bkw commented Nov 7, 2017

I think it would make a lot of sense to have a precompiled musl build to save on build dependencies.
Is there any place I could add an alpine build to the release pipeline? I can't seem to find where the precompiled binaries are actually being build or uploaded. Is that a kokoro thing, perhaps?

@bkw
Copy link
Contributor Author

bkw commented Nov 9, 2017

Is there anything else I can do to push this forward?

@murgatroid99 murgatroid99 changed the base branch from master to v1.7.x November 9, 2017 18:32
@murgatroid99 murgatroid99 changed the base branch from v1.7.x to master November 9, 2017 18:32
@loganbfisher
Copy link

loganbfisher commented Nov 11, 2017

Is there any way this can get merged? We are running into this problem with a number of our images currently. Thanks for the fix!

@victorperin
Copy link

Same here, delaying deploys of some features too. :)

@BrunoQuaresma
Copy link

Any prediction of launch new version?

@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants