Resolve exception when Error.stackTraceLimit is undefined #2701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some applications may explicitly set Error.stackTraceLimit = undefined. In this case it is not safe to assume new Error().stack is available.
The committers listed above are authorized under a signed CLA. |
murgatroid99
added a commit
that referenced
this pull request
Apr 1, 2024
…kport Backport #2701: Resolve exception when Error.stackTraceLimit is undefined
|
This is out in version 1.10.5. |
This was referenced Jun 2, 2024
This was referenced Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some applications may explicitly set
Error.stackTraceLimit = undefined.In this case it is not safe to assume
new Error().stackis available using the!operator.Before this patch, using grpc-js in this situation when an Error occurs or when a trace is needed may result in uncaught exceptions crashing the application.
One thing I considered is that often stack traces are indented by four spaces by the JS engine such as node. My default message for clarity is just
no track trace availableversus using the magic number of spaces. I'm torn on the right solution here, but I personal prefer the clarity of a plain string rather than assuming our environment is one which adds random spaces to make CLI focused output prettier.