Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(grpc-native-core): incomplete function check #1786

Merged
merged 1 commit into from
May 14, 2021
Merged

fix(grpc-native-core): incomplete function check #1786

merged 1 commit into from
May 14, 2021

Conversation

amje
Copy link

@amje amje commented May 13, 2021

Current check is not working for async functions:

toString.call(async function() {}); // [object AsyncFunction]

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented May 13, 2021 •
edited
Loading

CLA Signed

The committers are authorized under a signed CLA.

@amje amje force-pushed the fix-function-check branch from e96ed93 to b1c1f96 Compare May 13, 2021 15:59
@murgatroid99
Copy link
Member

Thank you for fixing this. I can't accept the PR until you sign the CLA.

This was referenced May 13, 2021
Merged
Closed
@amje
Copy link
Author

amje commented May 14, 2021

Thank you for fixing this. I can't accept the PR until you sign the CLA.

I've signed the CLA

@murgatroid99 murgatroid99 merged commit d85324d into grpc:grpc@1.24.x May 14, 2021
@amje amje deleted the fix-function-check branch May 14, 2021 21:10
@murgatroid99 murgatroid99 mentioned this pull request May 14, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@murgatroid99 murgatroid99 murgatroid99 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amje @murgatroid99