Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert Provider use in AndroidChannelBuilder and okhttp compileOnly #9039

Closed
wants to merge 2 commits into from

Conversation

ejona86
Copy link
Member

@ejona86 ejona86 commented Mar 31, 2022

Revert #9003 and partly revert #8971. The two commits will be kept separate when merging. There are details in the two commits, but essentially #9003 is incompatible with Proguard and we don't want users to need Proguard configuration.

CC @beatrausch

There's a few options to roll forward, but it'll need to be discussed.

…)"

This partly reverts b20ce17 because it is dependent on cda0e9d which is
being reverted as it is incompatible with Proguard without configuration
(e.g., isAvailable() may not be available and would need a -keep).

While the code no longer uses compileOnly, the compatibility still
remains, so it would be possible for users to exclude the okhttp
dependency if they don't use AndroidChannelBuilder.
This reverts commit cda0e9d. The change
was incompatible with Proguard without additional configuration. For
example, isAvailable() may not be available and would need a -keep.
@ejona86
Copy link
Member Author

ejona86 commented Mar 31, 2022

Also, ironically, when using Proguard compileOnly is safe without #9003.

@ejona86
Copy link
Member Author

ejona86 commented Mar 31, 2022

CC @temawi

@ejona86
Copy link
Member Author

ejona86 commented Mar 31, 2022

#9040 is the fix. We can either rollback now, or just fix-forward.

@ejona86
Copy link
Member Author

ejona86 commented Mar 31, 2022

Closing in favor of fix-forward in #9040

@ejona86 ejona86 closed this Mar 31, 2022
@ejona86 ejona86 deleted the okhttp-compileonly-revert branch March 31, 2022 18:53
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants