-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xds: add xds end to end interop test #8618
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
interop-testing/src/main/java/io/grpc/testing/integration/AbstractXdsInteropTest.java
Outdated
Show resolved
Hide resolved
interop-testing/src/main/java/io/grpc/testing/integration/XdsTestControlPlaneService.java
Outdated
Show resolved
Hide resolved
interop-testing/src/main/java/io/grpc/testing/integration/XdsTestControlPlaneService.java
Outdated
Show resolved
Hide resolved
interop-testing/src/main/java/io/grpc/testing/integration/XdsTestControlPlaneService.java
Show resolved
Hide resolved
interop-testing/src/main/java/io/grpc/testing/integration/XdsTestControlPlaneService.java
Show resolved
Hide resolved
interop-testing/src/main/java/io/grpc/testing/integration/XdsTestControlPlaneService.java
Outdated
Show resolved
Hide resolved
dapengzhang0
reviewed
Nov 1, 2021
interop-testing/src/main/java/io/grpc/testing/integration/XdsTestControlPlaneService.java
Outdated
Show resolved
Hide resolved
interop-testing/src/main/java/io/grpc/testing/integration/XdsTestControlPlaneService.java
Outdated
Show resolved
Hide resolved
dapengzhang0
approved these changes
Nov 2, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
YifeiZhuang
added a commit
to YifeiZhuang/grpc-java
that referenced
this pull request
Nov 3, 2021
This reverts commit 0000cba.
YifeiZhuang
added a commit
that referenced
this pull request
Nov 3, 2021
beatrausch
pushed a commit
to beatrausch/grpc-java
that referenced
this pull request
Nov 4, 2021
Add AbstractXdsInteropTest, XdsTestControlPlaneService and only ping-pong testcase in initial implementation. AbstractXdsInteropTest sets up the test control plane, create xdsClient and xdServer using bootstrap override, test case extending AbstractXdsInteropTest is supposed to override the control plane config and run the verification. XdsTestControlPlaneService only has static xds configurations, not able to keep states. How to run: ./gradlew :grpc-interop-testing:installDist -PskipCodegen=true ./interop-testing/build/install/grpc-interop-testing/bin/xds-e2e-test-client
beatrausch
pushed a commit
to beatrausch/grpc-java
that referenced
this pull request
Nov 4, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
AbstractXdsInteropTest
,XdsTestControlPlaneService
and only ping-pong testcase in initial implementation.AbstractXdsInteropTest
sets up the test control plane, create xdsClient and xdServer using bootstrap override, test case extendingAbstractXdsInteropTest
is supposed to override the control plane config and run the verification.XdsTestControlPlaneService
only has static xds configurations, not able to keep states.