Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: change the mapping from ChannelLogLevel to java.util.logging.Level #8531

Merged
merged 1 commit into from
Sep 22, 2021

Conversation

ZhouyihaiDing
Copy link
Contributor

@ZhouyihaiDing ZhouyihaiDing commented Sep 17, 2021

Instead of ChannelLogLevel.{DEBUG,INFO} mapping to the same java level, ChannelLogLevel.{WARNING,ERROR} will shame the same java level. This allows us to be able to independently control the visibility of ChannelLogLevel.DEBUG logs which are the most verbose.

@zhangkun83 zhangkun83 changed the title Update ChannelLogger to Java logger level mapping core: change the mapping from ChannelLogLevel to java.util.LogLevel Sep 21, 2021
@zhangkun83 zhangkun83 changed the title core: change the mapping from ChannelLogLevel to java.util.LogLevel core: change the mapping from ChannelLogLevel to java.util.logging.Level Sep 21, 2021
Copy link
Contributor

@zhangkun83 zhangkun83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhangkun83 zhangkun83 merged commit e41df60 into grpc:master Sep 22, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants