netty: allow to use bandwidth delay product #6979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
creamsoup
commented
Apr 24, 2020
•
creamsoup
commented
- avoid ping spam after WINDOW_UPDATE, DATA frame
- allow to set initialWindowUpdate for Netty{Channel,Server}Builder which enables bdp
- remove InternalHandlerSettings, NettyHandlerSettings
ejona86
reviewed
Apr 28, 2020
| private static synchronized int getLatestWindow(AbstractNettyHandler handler) { | ||
| Preconditions.checkNotNull(handler); | ||
| return handler.decoder().flowController() | ||
| .initialWindowSize(handler.connection().connectionStream()); | ||
| } | ||
|
|
||
| static ChannelFutureListener cleanUpTask() { |
There was a problem hiding this comment.
I'm fiercely annoyed by the storage of these handlers and the dance to clean them up. (Not your code, their existence.)
What do you think about having NettyFlowControlTest create a custom ProtocolNegotiator that grabs the GrpcHttp2ConnectionHandler and we pass that to getLatestWindow() (so we would cast to AbstractNettyHandler in this class)?
(I'm also fine at that point trashing this class and just having InternalHandlerSettings)
There was a problem hiding this comment.
done. using ProtocolNegotiator made the conversion very easy.
ejona86
approved these changes
May 1, 2020
|
|
||
| @Override | ||
| public void close() { | ||
| delegate.close();; |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.