Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TCP_USER_TIMEOUT property setting issue fixed #11564

Merged
merged 6 commits into from
Oct 22, 2024

Conversation

hlx502
Copy link
Contributor

@hlx502 hlx502 commented Sep 27, 2024

In NettyClientTransport, the TCP_USER_TIMEOUT attribute can be set only if the channel is of the AbstractEpollStreamChannel.

Fixes #11517

@ejona86
Copy link
Member

ejona86 commented Oct 3, 2024

Note that checkstyle is failing due to a long line.

@hlx502 hlx502 closed this Oct 10, 2024
…ly if the channel is of the AbstractEpollStreamChannel.
@hlx502 hlx502 reopened this Oct 10, 2024
Copy link
Member

@ejona86 ejona86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ejona86 ejona86 added the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Oct 21, 2024
@ejona86
Copy link
Member

ejona86 commented Oct 21, 2024

@kannanjgithub, can you review?

@grpc-kokoro grpc-kokoro removed the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Oct 21, 2024
@ejona86 ejona86 merged commit 62f4098 into grpc:master Oct 22, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TCP_USER_TIMEOUT property setting issue
4 participants