.github/workflows: Bump action major versions #11476
Conversation
GitHub began the Node16 deprecation process a year ago [1][2]. This commit updates all workflows to use the latest Node20 actions. [1]: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/ [2]: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/ Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
| uses: codecov/codecov-action@v4 | ||
| with: | ||
| token: ${{ secrets.CODECOV_TOKEN }} |
There was a problem hiding this comment.
This is the only breaking change introduced by this PR.
Codecov v4 no longer supports tokenless uploading, see https://github.com/codecov/codecov-action/tree/v4.5.0?tab=readme-ov-file#breaking-changes.
Important
Maintainers need to follow https://docs.codecov.com/docs/adding-the-codecov-token#github-actions and set the CODECOV_TOKEN secret
In v3, there is a rate limit for uploading without token. We have been rate limited in a lot of our workflow runs, see https://github.com/grpc/grpc-java/actions/runs/10389467357/job/28767544204#step:11:33
[2024-08-14T14:34:26.016Z] ['error'] There was an error running the uploader: Error uploading to [https://codecov.io:](https://codecov.io/) Error: There was an error fetching the storage URL during POST: 429 - {"message":"Rate limit reached. Please upload with the Codecov repository upload token to resolve issue. Expected time to availability: 1732s."}
There was a problem hiding this comment.
Looks like we haven't had a working codecov since May. Weird they didn't produce any error and instead just didn't provide a build status. "Codecov will exit with status code 0. If you are expecting a non-zero exit code, please pass in the -Z flag" sigh. Looks like that is controlled with fail_ci_if_error: true. Although we have to choose between failing the entire build.
I've added this secret, so this should be fine now.
| @@ -13,7 +13,7 @@ jobs: | |||
| lock: | |||
| runs-on: ubuntu-latest | |||
| steps: | |||
| - uses: dessant/lock-threads@v4 | |||
| - uses: dessant/lock-threads@v5 | |||
There was a problem hiding this comment.
This will now lock discussions. The default is after 365 days. That seems okay.
| uses: codecov/codecov-action@v4 | ||
| with: | ||
| token: ${{ secrets.CODECOV_TOKEN }} |
There was a problem hiding this comment.
Looks like we haven't had a working codecov since May. Weird they didn't produce any error and instead just didn't provide a build status. "Codecov will exit with status code 0. If you are expecting a non-zero exit code, please pass in the -Z flag" sigh. Looks like that is controlled with fail_ci_if_error: true. Although we have to choose between failing the entire build.
I've added this secret, so this should be fine now.
ejona86
added
the
kokoro:run
grpc-kokoro
removed
the
kokoro:run
GitHub began the Node16 deprecation process a year ago 12. This PR updates all workflows to use the latest Node20 actions. I have tested the workflows in my fork repository.
The last update was made almost two years ago in PR #9648.
Footnotes
https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/ ↩
https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/ ↩