examples: add an example for OAuth #10560
Conversation
| @Override | ||
| public <ReqT, RespT> ServerCall.Listener<ReqT> interceptCall(ServerCall<ReqT, RespT> serverCall, | ||
| Metadata metadata, ServerCallHandler<ReqT, RespT> serverCallHandler) { | ||
| String value = metadata.get(Constant.AUTHORIZATION_METADATA_KEY); |
There was a problem hiding this comment.
I would change "value" to something like "authorizationHeader".
| } | ||
| } | ||
|
|
||
| serverCall.close(status, new Metadata()); |
There was a problem hiding this comment.
Add a comment about closing the server call and not allowing any other processing to be done on the request because verification of the header failed?
| private Constant() { | ||
| throw new AssertionError(); | ||
| } |
There was a problem hiding this comment.
nit: Don't really need this...
There was a problem hiding this comment.
|
|
||
|
|
||
| /** | ||
| * Refreshes access token by simply appending ":+1" to the previous value. |
There was a problem hiding this comment.
Mention what a real implementation would generally have to do here?
| } | ||
|
|
||
| /** | ||
| * Construct client for accessing GreeterGrpc server using the existing channel. |
There was a problem hiding this comment.
You mean "Construct a client..." ?
There was a problem hiding this comment.
Heh, I meant "using an existing channel"
But now that you mention it, your suggestion should be done as well 😄
| * This interceptor gets the OAuth2 access token from metadata, verifies it and sets the client | ||
| * identifier obtained from the token into the context. The one check it does on the access token | ||
| * is that the token has been refreshed at least once. |
There was a problem hiding this comment.
Talk about what a real implementation would generally need to do to verify the token?
| import com.google.auth.oauth2.AccessToken; | ||
| import com.google.auth.oauth2.OAuth2Credentials; |
There was a problem hiding this comment.
We are relying on Google client APIs here. As a user this would make me think that either:
- gRPC only supports oauth if I couple my app with Google libraries
- This example is specific to Google libraries and I don't have a good example of what to do if I don't use Google libraries
Explain somewhere (maybe in README.md) what the deal is?
There was a problem hiding this comment.
Good point. @ejona86 and I talked about it. I'll add some explanation in the README
|
😄 |
No description provided.