fixed StaticStrideScheduler looping too many times #10370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YifeiZhuang
approved these changes
Jul 11, 2023
tonyjongyoonan
added
the
kokoro:force-run
grpc-kokoro
removed
the
kokoro:force-run
tonyjongyoonan
added
bug
TODO:release blocker
ejona86
approved these changes
Jul 13, 2023
tonyjongyoonan
added
the
kokoro:force-run
grpc-kokoro
removed
the
kokoro:force-run
ejona86
removed
TODO:release blocker
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#10366 details a bug with the new implementation of the weighted round robin earliest deadline first scheduler, StaticStrideScheduler.
This bug was fixed by properly scaling the mean weight in the edge case where all subchannel weights are invalid and making sure they have correct casting and rounding logic. An assert statement was added to check for cases with many passthroughs and test cases were also made to be more strict to better verify behavior.