Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bazel building is broken with protobuf<3.6.1.3 #5310

Closed
Reflexe opened this issue Feb 1, 2019 · 3 comments · Fixed by #5320
Closed

Bazel building is broken with protobuf<3.6.1.3 #5310

Reflexe opened this issue Feb 1, 2019 · 3 comments · Fixed by #5320

Comments

@Reflexe
Copy link

Reflexe commented Feb 1, 2019

What version of gRPC are you using?

1.18.0

What did you expect to see?

Bazel build is working; currently it is broken since old protobuf versions uses the removed REPOSITORY_NAME and PACKAGE_NAME (see protocolbuffers/protobuf@af48106).

Solution

Bump protobuf to 3.6.1.3?
@perezd
Copy link
Contributor

perezd commented Feb 3, 2019

protocolbuffers/protobuf#5547

I believe a new version is coming out next week that we should encourage everyone to upgrade to.

@Reflexe
Copy link
Author

Reflexe commented Feb 4, 2019

For now, we could switch to the 3.6.1.3 tag; it has solved the issue for me.

@ejona86
Copy link
Member

ejona86 commented Feb 5, 2019 •
edited by dapengzhang0
Loading

This will be fixed by #5310. That PR should not block users, as you can manually specify the newer version.

Edit: you meant 5320?

@ejona86 ejona86 mentioned this issue Feb 5, 2019
Merged
@lock lock bot locked as resolved and limited conversation to collaborators May 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upgrade to protobuf 3.6.1 ejona86/grpc-java
3 participants
@perezd @ejona86 @Reflexe