Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protoc-gen-go-grpc: skip TestUnimplementedEmbedding #8017

Closed
wants to merge 1 commit into from

Conversation

purnesh42H
Copy link
Contributor

@purnesh42H purnesh42H commented Jan 17, 2025

We need to skip the TestUnimplementedEmbedding until google3 usages are fixed to embed UnimplementedTestServiceServer

RELEASE NOTES: None

Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.05%. Comparing base (c879198) to head (fcf3491).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8017      +/-   ##
==========================================
+ Coverage   82.04%   82.05%   +0.01%     
==========================================
  Files         384      384              
  Lines       38750    38750              
==========================================
+ Hits        31792    31798       +6     
+ Misses       5632     5627       -5     
+ Partials     1326     1325       -1     

see 16 files with indirect coverage changes

@dfawley
Copy link
Member

dfawley commented Jan 17, 2025

Let's just not import this file, instead, since it's the only test in it. We don't want to reduce OSS test coverage due to an internal issue.

@dfawley dfawley closed this Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants