Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #7754 into v1.68.x #7813

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Conversation

purnesh42H
Copy link
Contributor

Original PR: #7754

RELEASE NOTES:

  • credentials: TLS credentials created via NewTLS that use tls.Config.GetConfigForClient will now have necessary gRPC-Go defaults, namely CipherSuites, supported TLS versions and ALPN configured automatically. This handling was already present for configs not using the GetConfigForClient function.

@purnesh42H purnesh42H requested a review from arjan-bal November 6, 2024 08:02
@arjan-bal arjan-bal added this to the 1.68 Release milestone Nov 6, 2024
@arjan-bal arjan-bal added the Type: Feature New features or improvements in behavior label Nov 6, 2024
Copy link

codecov bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.65%. Comparing base (056dc64) to head (bcfee8a).
Report is 1 commits behind head on v1.68.x.

Additional details and impacted files
@@             Coverage Diff             @@
##           v1.68.x    #7813      +/-   ##
===========================================
- Coverage    81.80%   81.65%   -0.16%     
===========================================
  Files          364      364              
  Lines        35899    35910      +11     
===========================================
- Hits         29367    29321      -46     
- Misses        5345     5384      +39     
- Partials      1187     1205      +18     
Files with missing lines Coverage Δ
credentials/tls.go 86.57% <100.00%> (+1.06%) ⬆️

... and 21 files with indirect coverage changes

@purnesh42H purnesh42H merged commit 5363dca into grpc:v1.68.x Nov 6, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature New features or improvements in behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants