Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cherry-pick #7557 to v1.66.x branch #7564

Merged
merged 1 commit into from
Aug 26, 2024
Merged

cherry-pick #7557 to v1.66.x branch #7564

merged 1 commit into from
Aug 26, 2024

Conversation

dfawley
Copy link
Member

@dfawley dfawley commented Aug 26, 2024

RELEASE NOTES: none

@dfawley dfawley added this to the 1.66 Release milestone Aug 26, 2024
@dfawley dfawley requested a review from arvindbr8 August 26, 2024 16:23
Copy link

codecov bot commented Aug 26, 2024

Codecov Report

Attention: Patch coverage is 75.86207% with 7 lines in your changes missing coverage. Please review.

Project coverage is 81.87%. Comparing base (62baa5f) to head (e1cba78).
Report is 1 commits behind head on v1.66.x.

Files Patch % Lines
encoding/proto/proto.go 72.72% 4 Missing and 2 partials ⚠️
codec.go 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           v1.66.x    #7564      +/-   ##
===========================================
- Coverage    81.89%   81.87%   -0.03%     
===========================================
  Files          362      361       -1     
  Lines        27865    27849      -16     
===========================================
- Hits         22820    22800      -20     
- Misses        3843     3854      +11     
+ Partials      1202     1195       -7     
Files Coverage Δ
encoding/encoding.go 56.25% <100.00%> (-17.09%) ⬇️
encoding/encoding_v2.go 60.00% <100.00%> (+4.44%) ⬆️
codec.go 10.52% <50.00%> (-72.09%) ⬇️
encoding/proto/proto.go 66.66% <72.72%> (ø)

... and 17 files with indirect coverage changes

@dfawley dfawley merged commit 8e3596c into grpc:v1.66.x Aug 26, 2024
13 of 14 checks passed
@dfawley dfawley deleted the cp branch August 26, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants