codes: replace %q to %d in error string when invalid code is an integer

[purnesh42H]

7174(Minor 'invalid code' error output suggestion) raises an issue from implementation https://github.com/grpc/grpc-go/blob/b433b9467d87d70de277ee7e1139ef2ad900bfa4/codes/codes.go that line 238 fmt.Errorf("invalid code: %q", ci) will interpret the uint64 value as a Unicode code point and attempt to print the corresponding character. However, if invalid code is an integer and we already parsed ci as Uint, it is better to use %d instead of %q for the better output.

Before Change, code.UnmarshalJson("200") returns "invalid code: 'E'"

After change, code.UnmarshalJson("200") returns "invalid code: 200"

RELEASE NOTES: N/A

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: purnesh42H / name: Purnesh Dixit (6b02a21, 2e6251c, 8eb5431, a91f90d, a6f25ed)

[arjan-bal]

LGTM

[aranjans]

LGTM!

[easwars]

Also, for the PR title, we usually follow the following format:
package: <description starting with a lower case>

So, this would be:
codes: replace %q to %d in error string when invalid code is an integer

[purnesh42H]

Also, for the PR title, we usually follow the following format: package: <description starting with a lower case>

So, this would be: codes: replace %q to %d in error string when invalid code is an integer

Done

[easwars]

Also, while you are here, could you also please change the call to reflect.DeepEqual() with a call to cmp.Equal in TestJSONUnmarshal. The latter is preferred over the former. See: https://google.github.io/styleguide/go/decisions#equality-comparison-and-diffs. Thanks.

[purnesh42H]

Also, while you are here, could you also please change the call to reflect.DeepEqual() with a call to cmp.Equal in TestJSONUnmarshal. The latter is preferred over the former. See: https://google.github.io/styleguide/go/decisions#equality-comparison-and-diffs. Thanks.

Done

[easwars]

LGTM modulo the one last minor nit.

[easwars]

The error message should have a = instead of a != because we are printing got before want.

[purnesh42H]

Good catch. Done