Don't call cmp in non-testing file #5359
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
menghanl
suggested changes
May 17, 2022
| return false | ||
| } | ||
| return cmp.Equal(lbc.ChildPolicy, lbc2.ChildPolicy) | ||
| return lbc.FailurePercentageEjection.Equal(lbc2.FailurePercentageEjection) |
There was a problem hiding this comment.
You shouldn't just ignore the child policy field.
There was a problem hiding this comment.
I think the problem is, you shouldn't use *outlierdetection.LBConfig as the field in DiscoveryMechanism. It should be a config message without the child policy, because the child policy is specified by another field. Then you won't need an Equal method for this LBConfig type
This is I believe a missing piece in the outlier detection gRFC.
It needs to also specify what the new ClusterResolver balancer's config should look like.
|
Replaced by #5370 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #5353.
The config's Equal method is called by CDS to check the equality of discovery mechanisms. However, due to the fact that the Child Policy will not be prepared by the CDS Balancer, but will be prepared by the Cluster Resolver balancer, getting rid of the check is a logical no-op.
The config's Equal method is also called by the cmp package for testing purposes. However, to not have it call cmp.Equal to compare the child policy, I will switch my PR out (#5304) to manually compare the child policies in tests.
RELEASE NOTES: None