Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xdsclient/csds: fix leaked metadata #5339

Merged
merged 1 commit into from
May 9, 2022
Merged

Conversation

menghanl
Copy link
Contributor

@menghanl menghanl commented May 6, 2022

Fixed a typo. That causes a metadata to be written in a wrong map, thus will be leaked in CSDS

RELEASE NOTES: N/A

@menghanl menghanl requested review from dfawley and zasweq May 6, 2022 21:21
@menghanl menghanl added this to the 1.47 Release milestone May 6, 2022
Copy link
Member

@dfawley dfawley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@menghanl
Copy link
Contributor Author

menghanl commented May 6, 2022

🙈

@lidizheng
Copy link
Contributor

Good finding! Thanks for the fix. Do we want to backport?

Copy link
Contributor

@zasweq zasweq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@menghanl menghanl merged commit 5c46f1a into grpc:master May 9, 2022
@menghanl menghanl deleted the csds_md_fix branch May 9, 2022 18:06
dfawley pushed a commit to dfawley/grpc-go that referenced this pull request May 13, 2022
dfawley pushed a commit that referenced this pull request May 13, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants