Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xds/c2p: replace C2P resolver env var with experimental scheme suffix #5044

Merged
merged 1 commit into from
Dec 7, 2021

Conversation

apolcyn
Copy link
Contributor

@apolcyn apolcyn commented Dec 7, 2021

This is a Go analogue of grpc/grpc#28294

RELEASE NOTES: N/A

Copy link
Contributor

@menghanl menghanl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Will wait for the grpc/grpc PR before merging.

@menghanl menghanl added the Type: Internal Cleanup Refactors, etc label Dec 7, 2021
@menghanl menghanl added this to the 1.44 Release milestone Dec 7, 2021
@menghanl menghanl added Type: Behavior Change Behavior changes not categorized as bugs and removed Type: Internal Cleanup Refactors, etc labels Dec 7, 2021
@apolcyn
Copy link
Contributor Author

apolcyn commented Dec 7, 2021

C-core PR has been merged

@menghanl menghanl changed the title Replace C2P resolver env var with experimental scheme suffix xds/c2p: replace C2P resolver env var with experimental scheme suffix Dec 7, 2021
@menghanl menghanl merged commit a722e6a into grpc:master Dec 7, 2021
apolcyn added a commit to apolcyn/grpc-go that referenced this pull request Dec 7, 2021
@dfawley dfawley modified the milestones: 1.44 Release, 1.43 release Dec 8, 2021
dfawley pushed a commit that referenced this pull request Dec 8, 2021
codyoss pushed a commit to googleapis/google-api-go-client that referenced this pull request Dec 21, 2021
Follow grpc/grpc-go#5044 to update the xds scheme for DirectPath.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Type: Behavior Change Behavior changes not categorized as bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants