server: prevent hang in Go HTTP transport in some error cases #3833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfawley
reviewed
Aug 21, 2020
server.go
Outdated
| if e := t.WriteStatus(stream, st); e != nil { | ||
| channelz.Warningf(logger, s.channelzID, "grpc: Server.processUnaryRPC failed to write status %v", e) | ||
| } | ||
| st, _ := status.FromError(err) |
There was a problem hiding this comment.
Let's use toRPCErr instead for this conversion.
There was a problem hiding this comment.
Oh no.. maybe not. That doesn't guarantee a status is returned. It can return io.EOF. It is nicer than status.FromError in that it handles other types of errors, though.
There was a problem hiding this comment.
OK, this is good enough, then, since we don't expect it to not be a status in most cases. But please use status.Convert instead and remove the st variable.
dfawley
changed the title
dfawley
approved these changes
Aug 21, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3713