xds: server-side security: export WatchListener() from xdsClient #3817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
easwars
added
no release notes
Type: Feature
* This will be used from the xdsServer.
* Also fix one thing which was missed out in the xDS v3 support PR:
* Watches registered on the xdsClient should end up sending out
requests whose resource URL matches the transport version being
used.
* Blank import the v3 client package from xds package. Without this,
attempts to use v3 transport will fail.
easwars
force-pushed
the
xds_client_listeners
branch
from
01772b7
to
3ba6dab
Compare
menghanl
reviewed
Aug 14, 2020
| @@ -213,7 +268,7 @@ func (c *Client) watch(wi *watchInfo) (cancel func()) { | |||
| func (c *Client) watchLDS(serviceName string, cb func(ListenerUpdate, error)) (cancel func()) { | |||
| wi := &watchInfo{ | |||
| c: c, | |||
| typeURL: version.V2ListenerURL, | |||
| typeURL: c.listenerURL(), | |||
There was a problem hiding this comment.
Should we make an enum type for the types, and use that here? So that Client wouldn't need to deal with v2 and v3. The underlying versioned client can do the conversion.
We had this enum at the beginning (I think?), but later found it's not necessary, and we can just use the string. Now with two versions, the enum might make more sense.
There was a problem hiding this comment.
I think making that change has definitely made the code a little cleaner. But now the change is huge :(
easwars
force-pushed
the
xds_client_listeners
branch
from
6307a12
to
359dd69
Compare
|
PTAL. |
menghanl
approved these changes
Aug 18, 2020
easwars
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requests whose resource URL matches the transport version being
used.
attempts to use v3 transport will fail.