Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

client: properly check GRPC_GO_IGNORE_TXT_ERRORS environment variable #3532

Merged
merged 1 commit into from
Apr 17, 2020
Merged

client: properly check GRPC_GO_IGNORE_TXT_ERRORS environment variable #3532

merged 1 commit into from
Apr 17, 2020

Conversation

t33m
Copy link
Contributor

@t33m t33m commented Apr 15, 2020

I think we need check GRPC_GO_IGNORE_TXT_ERRORS instead of GRPC_GO_RETRY for value of TXTErrIgnore variable.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Apr 15, 2020 •
edited
Loading

CLA Check
The committers are authorized under a signed CLA.

@t33m t33m marked this pull request as draft April 15, 2020 08:34
@t33m t33m marked this pull request as ready for review April 15, 2020 08:35
@t33m t33m marked this pull request as draft April 15, 2020 08:35
@t33m t33m marked this pull request as ready for review April 15, 2020 12:51
@easwars
Copy link
Contributor

easwars commented Apr 15, 2020

Could you please sign the CLA.

@t33m t33m closed this Apr 16, 2020
@t33m t33m reopened this Apr 16, 2020
@t33m
Copy link
Contributor Author

t33m commented Apr 16, 2020

I signed, but nothing changed. Also I tried create another PR with same changes, but without success.

@menghanl
Copy link
Contributor

Are the commits made with the same email address that you signed the CLA with?

@t33m t33m force-pushed the bugfix/check_grpc_go_ignore_txt_errors_env_var branch from 408f57e to 0cdfae6 Compare April 17, 2020 06:45
@t33m
Copy link
Contributor Author

t33m commented Apr 17, 2020

My mistake. Fixed

@t33m t33m removed their assignment Apr 17, 2020
@menghanl menghanl changed the title check GRPC_GO_IGNORE_TXT_ERRORS env var env: check GRPC_GO_IGNORE_TXT_ERRORS env var Apr 17, 2020
@menghanl menghanl merged commit aff515d into grpc:master Apr 17, 2020
@menghanl menghanl changed the title env: check GRPC_GO_IGNORE_TXT_ERRORS env var client: properly check GRPC_GO_IGNORE_TXT_ERRORS environment variable Apr 17, 2020
@menghanl menghanl added this to the 1.30 Release milestone Apr 17, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@menghanl menghanl menghanl approved these changes

Assignees
No one assigned
Labels
Type: Bug
Projects
None yet
Milestone
1.30 Release
Development

Successfully merging this pull request may close these issues.
3 participants
@t33m @easwars @menghanl