client: update state earlier to prevent resetTransport calls from killing good transports #2862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alls from killing good transports
menghanl
approved these changes
Jun 10, 2019
menghanl
reviewed
Jun 10, 2019
| @@ -736,6 +736,7 @@ func (ac *addrConn) connect() error { | |||
| return nil | |||
| } | |||
| ac.mu.Unlock() | |||
| ac.updateConnectivityState(connectivity.Connecting) | |||
There was a problem hiding this comment.
Add some comment so we don't delete it again later.
There was a problem hiding this comment.
Done. And we want the update before unlocking, not after.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.