Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is ServeHTTP still considered experimental #2793

Closed
wants to merge 1 commit into from

Conversation

pgherveou
Copy link

Hi there,
this is more a question than a PR, but I wanted to know whether or not this feature was still considered experimental after 2 years?
Also, could we detail the features mentioned by this comment ServeHTTP does not support some gRPC feature?

Let me know if there is a way I can help make this comment more detailed!

Hi there,
this is more a question than a PR, but I wanted to know whether or not this feature was still considered experimental after 2 years?
Also, could we detail the features mentioned by this comment `ServeHTTP does not support some gRPC feature`?

Let me know if there is a way I can help make this comment more detailed!
@thelinuxfoundation
Copy link

Thank you for your pull request. Before we can look at your contribution, we need to ensure all contributors are covered by a Contributor License Agreement.

After the following items are addressed, please respond with a new comment here, and the automated system will re-verify.

Regards,
CLA GitHub bot

@dfawley
Copy link
Member

dfawley commented Apr 29, 2019

Yes, this is still experimental and supported at "best-effort" level by the gRPC maintainers. See #2662 for more details on the feature disparity. If you would like to augment the godoc to include "an incomplete list of missing functionality" when ServeHTTP is used, I'd be OK with it.

@pgherveou
Copy link
Author

I guess I can just close this PR if it is still considered experimental and not recommended by the core team, it's not worth adding more details here.

@pgherveou pgherveou closed this Apr 29, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants