Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server: define ServerOption as interfaces #2784

Merged
merged 1 commit into from
Apr 26, 2019
Merged

server: define ServerOption as interfaces #2784

merged 1 commit into from
Apr 26, 2019

Conversation

menghanl
Copy link
Contributor

@menghanl menghanl commented Apr 22, 2019 •
edited
Loading

Instead of functions. So custom server options can be made by wrapping an
EmptyServerOption.

@menghanl
server: define ServerOption as interfaces
a4762fb 
Instead of functions, so custom server options can be made by wrapping an
EmptyServerOption.
@menghanl menghanl added the Type: Internal Cleanup Refactors, etc label Apr 22, 2019
@menghanl menghanl requested a review from dfawley April 22, 2019 21:09
@menghanl menghanl merged commit 1e6ab1e into grpc:master Apr 26, 2019
@menghanl menghanl deleted the server_options_interface branch April 26, 2019 17:33
@lock lock bot locked as resolved and limited conversation to collaborators Oct 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dfawley dfawley dfawley approved these changes

Assignees

@dfawley dfawley

Labels
Type: Internal Cleanup Refactors, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@menghanl @dfawley