Replace "golang.org/x/net/context" with "context" and stop supporting go1.6 #1160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
https://github.com/grpc-ecosystem/grpc-gateway would like to move to this ASAP. IMO the longer this difference exists the more pain there will be. |
|
We are holding this off because the proto context package change was reverted golang/protobuf#326 |
This was referenced Apr 4, 2017
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a experimental PR to replace
"golang.org/x/net/context"with"context".This also means we will stop supporting go1.6.
protoc-gen-goupdated their context in generated code toimport "context", regenerated pb.go files with latest protoc-gen-go don't build against grpc now.fixes #711