-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support proxy #1095
Support proxy #1095
Conversation
Add package proxy Add error ErrIneffective Deal with user header
c0c963b
to
2c9ce04
Compare
2c9ce04
to
8c1aded
Compare
Go already has an abstraction of We had exactly the same problem: dialing remote gRPC endpoints over HTTPS connect. We've built https://github.com/mwitkow/go-http-dialer and end-to-end integraiton tests gRPC plaintext and gRPC tls https://github.com/mwitkow/go-http-dialer/blob/master/test/grpc_e2e_test.go |
In the proposal, it's proposed that we need to kinds of mapping functions, MapName before name resolution and MapAddress after name resolution. Custom dialer only works in the case of MapAddress. |
The dialer gets the hostname in single connection mode so you definitely
can mapname as well (that's what we do).
Unless you're taking of mapname before hitting grpc.Naming then you're
right. But few people would be using Grpc.Naming and grpc LB with a proxy
connection.
…On Tue, 28 Feb 2017, 18:23 Menghan Li, ***@***.***> wrote:
In the proposal, it's proposed that we need to kinds of mapping functions,
MapName before name resolution and MapAddress after name resolution.
Custom dialer only works in the case of MapAddress.
If the name cannot be resolved, dialer won't work.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#1095 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AJNWoyK3e-xGVs8BB-p7DNkamKaNLa8sks5rhGYzgaJpZM4MNw9W>
.
|
Make sense. |
Support TCP-level proxies via the HTTP CONNECT request.
Implementes gRFC A1: grpc/proposal#4.