Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support proxy #1095

Closed
wants to merge 11 commits into from
Closed

Support proxy #1095

wants to merge 11 commits into from

Conversation

menghanl
Copy link
Contributor

Support TCP-level proxies via the HTTP CONNECT request.

Implementes gRFC A1: grpc/proposal#4.

@menghanl menghanl requested a review from markdroth February 27, 2017 23:25
@menghanl menghanl force-pushed the http_connect branch 11 times, most recently from c0c963b to 2c9ce04 Compare February 28, 2017 01:16
@mwitkow
Copy link
Contributor

mwitkow commented Feb 28, 2017

Go already has an abstraction of net.Dialer which can be usedto address both points of the https://github.com/grpc/proposal/pull/4/files proposal: allowing to overwrite the address and perform TCP-level operations before handing off to gRPC. Can we please use that instead to make the library more Go-canonical and just write sugar-APIs on top to make it look like gRPC C++?

We had exactly the same problem: dialing remote gRPC endpoints over HTTPS connect. We've built https://github.com/mwitkow/go-http-dialer and end-to-end integraiton tests gRPC plaintext and gRPC tls https://github.com/mwitkow/go-http-dialer/blob/master/test/grpc_e2e_test.go

@menghanl
Copy link
Contributor Author

In the proposal, it's proposed that we need to kinds of mapping functions, MapName before name resolution and MapAddress after name resolution.

Custom dialer only works in the case of MapAddress.
If the name cannot be resolved, dialer won't work.

@mwitkow
Copy link
Contributor

mwitkow commented Feb 28, 2017 via email

@menghanl
Copy link
Contributor Author

menghanl commented Mar 1, 2017

Make sense.
Close this and added #1098

@menghanl menghanl deleted the http_connect branch December 11, 2018 01:37
@lock lock bot locked as resolved and limited conversation to collaborators Jun 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants