Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing grpclb/state in grpc v1.52.0 #5928

Closed
haunt98 opened this issue Jan 12, 2023 · 4 comments · Fixed by #5962
Closed

Missing grpclb/state in grpc v1.52.0 #5928

haunt98 opened this issue Jan 12, 2023 · 4 comments · Fixed by #5962
Assignees
@dfawley
Labels
P1 Type: Bug

Comments

@haunt98
Copy link

haunt98 commented Jan 12, 2023

What version of gRPC are you using?

v1.52.0

What version of Go are you using (go version)?

go1.19.5

What operating system (Linux, Windows, …) and version?

macOS, Linux

What did you do?

I upgrade grpc-go as usual.

What did you expect to see?

go mod tidy successfully

What did you see instead?

google.golang.org/grpc/balancer/grpclb/state: module google.golang.org/grpc@latest found (v1.52.0), but does not contain package google.golang.org/grpc/balancer/grpclb/state
@dfawley
Copy link
Member

dfawley commented Jan 24, 2023

Sorry for the late reply here.

@easwars this package was renamed by #5826. It is not experimental, so this is not allowable.

@haunt98 are you using this package directly? If so, sorry for the breakage; we will fix it ASAP.

@dfawley dfawley added the P1 label Jan 24, 2023
@dfawley dfawley assigned dfawley and unassigned easwars Jan 24, 2023
@dfawley dfawley mentioned this issue Jan 24, 2023
Merged
dfawley added a commit that referenced this issue Jan 24, 2023
@dfawley
grpclb: rename grpclbstate package back to state (#5962)
894816c 
Fixes #5928
dfawley added a commit to dfawley/grpc-go that referenced this issue Jan 24, 2023
@dfawley
grpclb: rename grpclbstate package back to state (grpc#5962)
2325e53 
Fixes grpc#5928
@haunt98
Copy link
Author

haunt98 commented Jan 25, 2023

Thanks @dfawley! My company use this package to write custom dns resolver.

@dfawley
Copy link
Member

dfawley commented Jan 25, 2023

@haunt98 also FYI we made a release with the fix:

https://github.com/grpc/grpc-go/releases/tag/v1.52.1

@haunt98
Copy link
Author

haunt98 commented Jan 26, 2023

I've already upgraded to v1.52.1 So far so good. Thanks @dfawley!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@dfawley dfawley

Labels
P1 Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

grpclb: rename grpclbstate package back to state dfawley/grpc-go
3 participants
@easwars @haunt98 @dfawley