Skip to content

Commit

Permalink
googledirectpatph: enable ignore_resource_deletion in bootstrap (#6243)…
Browse files Browse the repository at this point in the history
… (#6246)
  • Loading branch information
dfawley authored May 2, 2023
1 parent 3fc6e00 commit d33f68e
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion xds/googledirectpath/googlec2p.go
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ func (c2pResolverBuilder) Build(t resolver.Target, cc resolver.ClientConn, opts
{
"server_uri": "%s",
"channel_creds": [{"type": "google_default"}],
"server_features": ["xds_v3"]
"server_features": ["xds_v3", "ignore_resource_deletion"]
}`, balancerName)))
if err != nil {
return nil, fmt.Errorf("failed to build bootstrap configuration: %v", err)
Expand Down
2 changes: 1 addition & 1 deletion xds/googledirectpath/googlec2p_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,7 @@ func TestBuildXDS(t *testing.T) {
wantServerConfig, err := bootstrap.ServerConfigFromJSON([]byte(fmt.Sprintf(`{
"server_uri": "%s",
"channel_creds": [{"type": "google_default"}],
"server_features": ["xds_v3"]
"server_features": ["xds_v3", "ignore_resource_deletion"]
}`, tdURL)))
if err != nil {
t.Fatalf("Failed to build server bootstrap config: %v", err)
Expand Down

0 comments on commit d33f68e

Please sign in to comment.