Skip to content

Commit

Permalink
client: rework resolver and balancer wrappers to avoid deadlock (#6804)
Browse files Browse the repository at this point in the history
  • Loading branch information
dfawley committed Dec 5, 2023
1 parent 93389b7 commit 5d7453e
Show file tree
Hide file tree
Showing 11 changed files with 696 additions and 646 deletions.
297 changes: 113 additions & 184 deletions balancer_wrapper.go

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion balancer_wrapper_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ func (s) TestBalancer_StateListenerBeforeConnect(t *testing.T) {
t.Error("Unexpected call to StateListener with:", scs)
},
})
if err != nil && !strings.Contains(err.Error(), "connection is closing") && !strings.Contains(err.Error(), "is deleted") && !strings.Contains(err.Error(), "is closed or idle") {
if err != nil && !strings.Contains(err.Error(), "connection is closing") && !strings.Contains(err.Error(), "is deleted") && !strings.Contains(err.Error(), "is closed or idle") && !strings.Contains(err.Error(), "balancer is being closed") {
t.Error("Unexpected error creating subconn:", err)
}
wg.Done()
Expand Down
Loading

0 comments on commit 5d7453e

Please sign in to comment.