Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for maxInboundMetadataSize client configuration #1064

Merged
merged 6 commits into from
Mar 13, 2024

Conversation

o-shevchenko
Copy link
Contributor

Add support for maxInboundMetadataSize client configuration.
If metadata (for example an exception message) exceeds the limit we may receive a client error:

io.grpc.StatusRuntimeException: INTERNAL: RST_STREAM closed stream. HTTP/2 error code: PROTOCOL_ERROR

See: https://grpc.github.io/grpc-java/javadoc/io/grpc/ManagedChannelBuilder.html#maxInboundMetadataSize(int)
See: https://github.com/LogNet/grpc-spring-boot-starter/blob/master/grpc-spring-boot-starter/src/main/java/org/lognet/springboot/grpc/autoconfigure/GRpcServerProperties.java#L128

ST-DDT
ST-DDT previously approved these changes Mar 6, 2024
@o-shevchenko
Copy link
Contributor Author

@ST-DDT Thanks for the review!
What is the process of merging this PR? When we should expect next release with these changes?
Thanks!

@ST-DDT
Copy link
Collaborator

ST-DDT commented Mar 7, 2024

What is the process of merging this PR?

I have some free time next week to look into that.

@o-shevchenko
Copy link
Contributor Author

o-shevchenko commented Mar 11, 2024

It will also be great to merge changes for retries config: #574.
The lack of available configs is really a blocker in using this lib

@ST-DDT ST-DDT merged commit d75fba5 into grpc-ecosystem:master Mar 13, 2024
1 check passed
@yidongnan yidongnan added this to the 3.1.0 milestone Apr 12, 2024
@o-shevchenko o-shevchenko deleted the maxInboundMetadataSize branch April 19, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants