ability to customize stream errors

[jhump]

Fixes #584

[johanbrandhorst]

Thanks a ton for this - really excited about this new functionality! How would you feel about also adding a section about configuring the stream errors to our documentation?

[jhump]

@johanbrandhorst, the build errors aren't making a lot of sense to me. I'm not a bazel user, but I understand the concepts (I've used blaze and pants). I tried to add a dependency from the runtime package to runtime/internal (surprised it was not already present), but that is still failing.

Any advice on getting the build green? I'm also really confused about the other errors, which appear to be related to Go modules. The confusing thing is that a few lines up from the error, it states that it resolved "github.com/grpc-ecosystem/grpc-gateway/runtime", but somehow can't resolve the "internal" sub-package therein :(

I can keep hacking, but if you can spot any simple issues in here, that would certainly speed things up.

[johanbrandhorst]

@johanbrandhorst, the build errors aren't making a lot of sense to me. I'm not a bazel user, but I understand the concepts (I've used blaze and pants). I tried to add a dependency from the runtime package to runtime/internal (surprised it was not already present), but that is still failing.

Any advice on getting the build green? I'm also really confused about the other errors, which appear to be related to Go modules. The confusing thing is that a few lines up from the error, it states that it resolved "github.com/grpc-ecosystem/grpc-gateway/runtime", but somehow can't resolve the "internal" sub-package therein :(

I can keep hacking, but if you can spot any simple issues in here, that would certainly speed things up.

Something about this import certainly seems to have got Go modules confused - I also have no idea what the hell is wrong here. I'll do some more investigating.

[johanbrandhorst]

Wait, runtime/internal isn't a package. You must mean github.com/grpc-ecosystem/grpc-gateway/internal? The internal package moved. @jhump.

[jhump]

Wait, runtime/internal isn't a package. You must mean github.com/grpc-ecosystem/grpc-gateway/internal? The internal package moved. @jhump.

Doh! Thanks for the tip. (You can probably tell that this patch was rebased from an older version of the repo. We've had it in a fork that is apparently pretty old: 463c5ed, from March 2018.)

[johanbrandhorst]

Wait, runtime/internal isn't a package. You must mean github.com/grpc-ecosystem/grpc-gateway/internal? The internal package moved. @jhump.

Doh! Thanks for the tip. (You can probably tell that this patch was rebased from an older version of the repo. We've had it in a fork that is apparently pretty old: 463c5ed, from March 2018.)

I celebrate the implication that you're trying to go back to the source :). I hope we can make you feel at home!

[codecov-io]

Codecov Report

Merging #930 into master will increase coverage by 0.03%.
The diff coverage is 81.08%.

@@            Coverage Diff             @@
##           master     #930      +/-   ##
==========================================
+ Coverage    53.5%   53.53%   +0.03%     
==========================================
  Files          40       40              
  Lines        3957     3964       +7     
==========================================
+ Hits         2117     2122       +5     
- Misses       1642     1645       +3     
+ Partials      198      197       -1

Impacted Files	Coverage Δ
runtime/proto_errors.go	34.88% <100%> (+34.88%)	⬆️
runtime/mux.go	44.88% <25%> (-0.65%)	⬇️
runtime/handler.go	35.34% <77.77%> (-5.29%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15c7b2e...281c6ca. Read the comment docs.

[jhump]

@johanbrandhorst: I think this is ready for another pass, whenever you get a chance.

[johanbrandhorst]

How do you feel about my suggestion to add some documentation about this new feature too?

[jhump]

How do you feel about my suggestion to add some documentation about this new feature too?

I added a section to the "Customizing your Gateway" doc page. PTAL.

[johanbrandhorst]

Thanks for this fantastic contribution!