Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Service, Method, Message Identifiers to be CamelCased #866

Merged
merged 1 commit into from
Feb 15, 2019

Conversation

waveywaves
Copy link
Contributor

@waveywaves waveywaves commented Feb 12, 2019

The incompatibility caused between the generated .pb.gw.go
and .pb.go files due to inconsistent identifier capitalization
has been fixed here.

Logic from protoc-gen-go for the Message, Service and Method
Names is ported to protoc-gen-grpc-gateway.

Have made changes in the template.go file and have written a
test so we don't regress this in the future.

This fixes #683

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@waveywaves
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@codecov-io
Copy link

codecov-io commented Feb 12, 2019

Codecov Report

Merging #866 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #866      +/-   ##
==========================================
+ Coverage   52.95%   52.99%   +0.03%     
==========================================
  Files          39       39              
  Lines        3907     3910       +3     
==========================================
+ Hits         2069     2072       +3     
  Misses       1642     1642              
  Partials      196      196
Impacted Files Coverage Δ
protoc-gen-grpc-gateway/gengateway/template.go 65.51% <100%> (+1.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45aec34...5b49183. Read the comment docs.

@achew22
Copy link
Collaborator

achew22 commented Feb 12, 2019

Thanks so much for the PR! Do you think you could add a test that verifies this behavior so we don't accidentally regress in the future?

@waveywaves
Copy link
Contributor Author

@achew22 Yes, I'll add a commit for the test in the PR. Thanks for checking.

The incompatibility caused between the generated .pb.gw.go
and .pb.go files due to inconsistent identifier capitalization
has been fixed here.

Logic from protoc-gen-go for the Message, Service and Method
Names is ported to protoc-gen-grpc-gateway.

Have made changes in the template.go file and have written a
test so we don't regress this in the future.

This fixes grpc-ecosystem#683
@waveywaves
Copy link
Contributor Author

Thanks so much for the PR! Do you think you could add a test that verifies this behavior so we don't accidentally regress in the future?

I have added the test and updated the PR

@waveywaves waveywaves changed the title Changed strings.Title to generator2.camelCase Updated Service, Method, Message Identifiers to be CamelCased Feb 15, 2019
Copy link
Collaborator

@johanbrandhorst johanbrandhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johanbrandhorst johanbrandhorst merged commit 8ce214f into grpc-ecosystem:master Feb 15, 2019
@johanbrandhorst
Copy link
Collaborator

Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

inconsistent identifier capitalization between protoc-gen-go and protoc-gen-grpc-gateway
5 participants