863 adding swagger annotation support for enum and nested objects #865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… object, repeated nested object and repeated primitive fields
|
Linked to issue 836 |
achew22
reviewed
Feb 11, 2019
achew22
reviewed
Feb 11, 2019
Codecov Report
@@ Coverage Diff @@
## master #865 +/- ##
==========================================
- Coverage 53.01% 52.95% -0.06%
==========================================
Files 39 39
Lines 3901 3907 +6
==========================================
+ Hits 2068 2069 +1
- Misses 1637 1642 +5
Partials 196 196
Continue to review full report at Codecov.
|
johanbrandhorst
approved these changes
Feb 13, 2019
There was a problem hiding this comment.
LGTM, I'll give @achew22 24 hours to voice anymore opinions before merging.
|
@fahernandez, thanks so much for finding a problem and reporting it but then going above and beyond to fix it for everyone! Really really great work. I look forward to doing it again soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.