Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added WithDisablePathLengthFallback option (to fix issue #447) #855

Merged
merged 1 commit into from
Jan 22, 2019
Merged

Added WithDisablePathLengthFallback option (to fix issue #447) #855

merged 1 commit into from
Jan 22, 2019

Conversation

UladzimirTrehubenka
Copy link
Contributor

See #447

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@codecov-io
Copy link

Codecov Report

Merging #855 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #855      +/-   ##
==========================================
+ Coverage   51.63%   51.67%   +0.03%     
==========================================
  Files          39       39              
  Lines        3788     3791       +3     
==========================================
+ Hits         1956     1959       +3     
  Misses       1647     1647              
  Partials      185      185
Impacted Files Coverage Δ
runtime/mux.go 45.52% <100%> (+1.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff4dc68...c9c7f46. Read the comment docs.

@achew22
Copy link
Collaborator

achew22 commented Jan 20, 2019

@UladzimirTrehubenka, this looks like a great way to fix it to me! Thanks so much for taking the time to investigate and fix the problem in a way that allows everyone to benefit. Looks like you need to do the CLA, and I'm going to give @johanbrandhorst a chance to look at it also, LGTM.

Copy link
Collaborator

@johanbrandhorst johanbrandhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@johanbrandhorst
Copy link
Collaborator

@UladzimirTrehubenka good to go as soon as you've signed the CLA.

@googlebot
Copy link

CLAs look good, thanks!

@johanbrandhorst johanbrandhorst merged commit 078fa17 into grpc-ecosystem:master Jan 22, 2019
adasari pushed a commit to adasari/grpc-gateway that referenced this pull request Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants