Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace complicated circle CI release with goreleaser. #828

Merged
merged 2 commits into from
Dec 21, 2018

Conversation

johanbrandhorst
Copy link
Collaborator

@johanbrandhorst johanbrandhorst commented Dec 8, 2018

Replace complicated circle CI release with goreleaser.

This job will only run on new tag creation and will automatically upload the binaries and create a changelog, however I think we'll manually want to copy the changelog from the one generated by the makefile job. Haven't found a way to turn off the changelog generation of gorelease but everything else is great so it's not that big of a problem.

@codecov-io
Copy link

codecov-io commented Dec 8, 2018

Codecov Report

Merging #828 into master will decrease coverage by 0.98%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #828      +/-   ##
==========================================
- Coverage   50.26%   49.28%   -0.99%     
==========================================
  Files          39       39              
  Lines        3752     3754       +2     
==========================================
- Hits         1886     1850      -36     
- Misses       1684     1726      +42     
+ Partials      182      178       -4
Impacted Files Coverage Δ
protoc-gen-swagger/main.go 25.27% <0%> (-0.87%) ⬇️
protoc-gen-swagger/genswagger/template.go 38.52% <0%> (-3.91%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11787b1...13d946a. Read the comment docs.

@johanbrandhorst johanbrandhorst force-pushed the re-enable-release-builds branch 9 times, most recently from 583c27d to 6f43f8f Compare December 21, 2018 13:38
@johanbrandhorst johanbrandhorst changed the title Re-enable release builds without -delete flag Replace complicated circle CI release with goreleaser. Dec 21, 2018
@johanbrandhorst johanbrandhorst merged commit 5b007c7 into master Dec 21, 2018
@johanbrandhorst johanbrandhorst deleted the re-enable-release-builds branch December 21, 2018 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants