Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write version to intermediate file for release publish #826

Merged
merged 1 commit into from
Dec 7, 2018

Conversation

johanbrandhorst
Copy link
Collaborator

This was failing because the git repo is not accessible when running the ghr command.

@johanbrandhorst johanbrandhorst force-pushed the fix-release-uploads branch 4 times, most recently from e3fbcda to 3f52fe1 Compare December 7, 2018 22:32
@codecov-io
Copy link

codecov-io commented Dec 7, 2018

Codecov Report

Merging #826 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #826   +/-   ##
=======================================
  Coverage   49.32%   49.32%           
=======================================
  Files          39       39           
  Lines        3751     3751           
=======================================
  Hits         1850     1850           
  Misses       1723     1723           
  Partials      178      178

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66f0e34...e2a8087. Read the comment docs.

@johanbrandhorst johanbrandhorst force-pushed the fix-release-uploads branch 7 times, most recently from 3054813 to 4366be0 Compare December 7, 2018 23:16
@johanbrandhorst
Copy link
Collaborator Author

Think I've finally got this done T_T

@johanbrandhorst johanbrandhorst merged commit 01c07cd into master Dec 7, 2018
@johanbrandhorst johanbrandhorst deleted the fix-release-uploads branch December 7, 2018 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants