Use newer Bazel repo rules #798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uses the new go_repository and http_archive rules. Using the former avoids a warning: DEPRECATED: the rules_go version of go_repository is deprecated. Migrate to the new version in @bazel_gazelle//def.bzl instead. The latter will avoid breakage when the native http_archive rule is disabled by default in a future version of Bazel.
|
Thanks for the contribution! Do you want to merge this before or after #797? |
Codecov Report
@@ Coverage Diff @@
## master #798 +/- ##
=======================================
Coverage 53.27% 53.27%
=======================================
Files 30 30
Lines 3369 3369
=======================================
Hits 1795 1795
Misses 1399 1399
Partials 175 175Continue to review full report at Codecov.
|
|
@johanbrandhorst Let's do it before if you don't have any comments here. They shouldn't conflict. (famous last words) |
|
I'll leave this to @achew22 now that he's shown signs of interest, but no objections on ordering to me. |
adasari
pushed a commit
to adasari/grpc-gateway
that referenced
this pull request
Apr 9, 2020
This uses the new go_repository and http_archive rules. Using the former avoids a warning: DEPRECATED: the rules_go version of go_repository is deprecated. Migrate to the new version in @bazel_gazelle//def.bzl instead. The latter will avoid breakage when the native http_archive rule is disabled by default in a future version of Bazel.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the new go_repository and http_archive rules. Using the former
avoids a warning:
DEPRECATED: the rules_go version of go_repository is deprecated. Migrate
to the new version in @bazel_gazelle//def.bzl instead.
The latter will avoid breakage when the native http_archive rule is
disabled by default in a future version of Bazel.