Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support to add list of required fields to objects generated in swagger.json #716

Conversation

srikanth6k
Copy link

In .proto file for each message we can add openapiv2_schema.json_schema option to generate some metadata about the message in swagger.json. As of now only title and description are supported. This change enables them to generate a list of required fields.

@codecov-io
Copy link

Codecov Report

Merging #716 into master will decrease coverage by 0.05%.
The diff coverage is 25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #716      +/-   ##
==========================================
- Coverage   56.43%   56.38%   -0.06%     
==========================================
  Files          30       30              
  Lines        3053     3056       +3     
==========================================
  Hits         1723     1723              
- Misses       1159     1162       +3     
  Partials      171      171
Impacted Files Coverage Δ
protoc-gen-swagger/genswagger/types.go 19.04% <ø> (ø) ⬆️
protoc-gen-swagger/genswagger/template.go 38.04% <25%> (-0.15%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a8ec3c...86d3692. Read the comment docs.

@srikanth6k srikanth6k closed this Aug 2, 2018
@srikanth6k srikanth6k reopened this Aug 2, 2018
@johanbrandhorst
Copy link
Collaborator

Looks to me like support for this was merged with #687

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants