Reorganize examples #618
Merged
Reorganize examples #618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 - CI failure appears to be intermittent issue with installing golint. |
yugui
force-pushed
the
refactor/example-pkg
branch
2 times, most recently
from
64c2b7a
to
668c9f2
Compare
because it is not a big issue even if just an example won't work with Go 1.6 or earlier.
as its network abstraction
to keep them consistent and keep their subdirectories shallower.
yugui
force-pushed
the
refactor/example-pkg
branch
from
668c9f2
to
80e88d0
Compare
Codecov Report
@@ Coverage Diff @@
## master #618 +/- ##
==========================================
+ Coverage 58.8% 59.28% +0.47%
==========================================
Files 29 28 -1
Lines 2840 2780 -60
==========================================
- Hits 1670 1648 -22
+ Misses 1005 971 -34
+ Partials 165 161 -4Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we have more examples and integration tests, the structure of the
examplesdirectory is getting more complicated.This PR reorganizes packages under
examples.