Pulled out parseReq func into a generic package + tests #600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achew22
approved these changes
Apr 15, 2018
codegenerator/parse_req_test.go
Outdated
| } | ||
|
|
||
| func mustGetReader(pb proto.Message) io.Reader { | ||
| b, _ := proto.Marshal(pb) |
There was a problem hiding this comment.
I would prefer to panic on error instead of silencing in a must function
protoc-gen-grpc-gateway/main.go
Outdated
| func main() { | ||
| flag.Parse() | ||
| defer glog.Flush() | ||
|
|
||
| reg := descriptor.NewRegistry() | ||
|
|
||
| glog.V(1).Info("Processing code generator request") | ||
| req, err := parseReq(os.Stdin) | ||
| glog.V(1).Info("Parsing code generator request") |
There was a problem hiding this comment.
Can you remove the one on line 37
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulled out the duplicated parseReq function into a more generic package and added tests to it.